ci: stop running push-triggered CI on renovate branches - #3873
Draft
nameless-mc wants to merge 1 commit into
Draft
ci: stop running push-triggered CI on renovate branches#3873nameless-mc wants to merge 1 commit into
nameless-mc wants to merge 1 commit into
Conversation
The test and lint workflows are triggered by both push (main and renovate/**) and pull_request, so every commit on a renovate branch runs the same CI twice: once for the push and once for the PR. Remove renovate/** from the push trigger and let the pull_request trigger cover renovate PRs. Renovate's automerge for this repository is PR-based (automergeType defaults to "pr"; the shared cybozu/renovate-config only uses branch automerge for CircleCI), so it relies on PR checks and does not need push-triggered runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
testandlintworkflows are triggered by bothpush(onmainandrenovate/**) andpull_request. Since Renovate always opens a PR for its branches, every commit on a renovate branch runs the same CI twice: once for the push event and once for the pull_request event. Renovate PRs account for most CI runs in this repository, so this duplication roughly doubles the CI workload for no additional signal.What
Remove
renovate/**from thepushtrigger oftest.ymlandlint.yml. Renovate PRs are still fully covered by thepull_requesttrigger, and pushes tomainkeep running CI as before.Renovate's automerge in this repository is PR-based (
automergeTypedefaults to"pr"; the sharedcybozu/renovate-configonly uses branch automerge for the CircleCI manager), so it relies on PR checks and does not need push-triggered runs. If branch automerge is ever enabled for npm, the push trigger would need to be restored.How to test
This is a trigger-only change and cannot be exercised locally:
renovate/**(grep -rn renovate .github/workflows/)Checklist
pnpm lintandpnpm teston the root directory.