Skip to content
This repository was archived by the owner on Jun 6, 2023. It is now read-only.
This repository was archived by the owner on Jun 6, 2023. It is now read-only.

ESLint hook doesn't stop commit on warnings #79

Open
Open
ESLint hook doesn't stop commit on warnings#79
Labels
ci/cd/releasePull requests and issues regarding CI, CD or release mechanismsmetaThings related to the repo, but not the codebase.

Description

@kiriDevs
kiriDevs
opened on Sep 1, 2022

The ESLint pre-commit hook doesn't stop a commit when a warning is thrown. I'd assume that also means the CI workflow still goes through, so we should make an extra script where ESLint actually exits with a non-zero code on warnings.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ci/cd/releasePull requests and issues regarding CI, CD or release mechanismsmetaThings related to the repo, but not the codebase.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions