event_types needs to be named event_types[] for Paymill to register mult... - #23
Open
ulfur wants to merge 1 commit into
Open
event_types needs to be named event_types[] for Paymill to register mult...#23ulfur wants to merge 1 commit into
ulfur wants to merge 1 commit into
Conversation
…ultiple events when creating new webhooks
Author
|
Hi, I noticed that this pull request has already been incorporated in the code, which is great! |
mbi
pushed a commit
to cruncher/pymill
that referenced
this pull request
Feb 6, 2018
Feature/expose http logging
mbi
pushed a commit
to cruncher/pymill
that referenced
this pull request
Feb 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on django-paymill (https://github.com/ulfur/django-paymill) and I'm basing it on pymill.
As django-paymill uses signals to deliver webhooks to the host application it needs to register one hook for all events. When testing the hook only registered for one of the events. This was the cause.