Skip to content

Stop waiting for npm to serve a new version after publishing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kova1max merged 1 commit into from
Sep 23, 2026
Merged

Stop waiting for npm to serve a new version after publishing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,9 @@ jobs:
# Trusted publishing: npm accepts this job's OIDC token because the
# package trusts kova1max/pullr + release.yml (set up with `npm trust`).
- run: npm publish
# npm processes a new version for a few minutes before serving it
# (3.5 minutes for 0.4.0), so poll for up to 10.
- name: Verify the published package runs
env:
VERSION: ${{ needs.release.outputs.version }}
run: |
out=""
for _ in $(seq 40); do
out="$(npx -y "@kova1/pullr@$VERSION" --version 2>/dev/null)" && break
sleep 15
done
test "$out" = "pullr $VERSION"
# No install check here: npm takes anywhere from minutes to over ten to
# serve a new version, so waiting on it made releases fail after a
# successful publish. npm publish exiting 0 is the confirmation.

github-packages:
needs: release
Expand Down
3 changes: 2 additions & 1 deletion RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ It runs as `github-actions[bot]` and:
5. points the formula in
[kova1max/homebrew-tap](https://github.com/kova1max/homebrew-tap) at the
new tag, using the `TAP_DEPLOY_KEY` secret (a write deploy key on the tap);
6. installs from npm and from the tap to verify both.
6. installs from the tap on macOS to verify the formula. (npm is not re-checked:
it can take over ten minutes to serve a new version.)
Loading