Use a global Config struct for arguments & accept log file as an argument - #17
Open
AJ-Williams1 wants to merge 2 commits into
Open
AJ-Williams1 wants to merge 2 commits into
AJ-Williams1 wants to merge 2 commits into
Conversation
gitfish7
approved these changes
Jul 28, 2025
gitfish7
left a comment
Contributor
There was a problem hiding this comment.
Looks good, do we have build + run validation to ensure no regressions?
gitfish7
suggested changes
Jul 28, 2025
gitfish7
left a comment
Contributor
There was a problem hiding this comment.
Changes look good, let's fix the commit messages and post some validation! Will approve after
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Firmware currently accepts command-line arguments for controlling policy-scale, kp-scale, and kd-scale. These arguments are parsed in
robot_description.rs, rather than early on inmain. This makes it difficult to add new arguments which affect other parts of the code--in this case an argument to specify where log files should be saved.Solution
Arguments are now parsed first thing, in
main, and placed into a Config struct. This struct is then passed through a series of functions toRobotDescription. I've also added an argument for the log file.