Skip to content

MSTEST0058/0061: fix the two MSTest analyzer diagnostics #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 1 commit into from
Aug 15, 2026
Merged

MSTEST0058/0061: fix the two MSTest analyzer diagnostics #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Semantics.Test/Paths/AbsoluteDirectoryPathParentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ public void Parent_OfRoot_ReturnsTheRootItself()
Assert.AreEqual(root, root.Parent);
}

/// <remarks>
/// UNC paths are Windows-only, so the test is skipped elsewhere rather than reporting
/// inconclusive from inside the body.
/// </remarks>
[TestMethod]
[OSCondition(OperatingSystems.Windows)]
[TestCategory("OS-Specific")]
public void Parent_OfUncShareRoot_ReturnsTheShareItself()
{
if (!OperatingSystem.IsWindows())
{
Assert.Inconclusive("UNC paths are Windows-only.");
return;
}

Assert.AreEqual(@"\\server\share", Dir(@"\\server\share\folder").Parent.WeakString);

AbsoluteDirectoryPath share = Dir(@"\\server\share");
Expand Down
13 changes: 4 additions & 9 deletions Semantics.Test/SemanticStringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,14 +1341,9 @@ public void SpanSplitEnumerator_OnlySeparators_HandlesCorrectly()
[TestMethod]
public void ErrorMessages_ContainTypeInformation()
{
try
{
ValidationTestSemanticString.Create("INVALID");
Assert.Fail("Expected ArgumentException");
}
catch (ArgumentException ex)
{
Assert.Contains(nameof(ValidationTestSemanticString), ex.Message);
}
ArgumentException ex = Assert.ThrowsExactly<ArgumentException>(
() => ValidationTestSemanticString.Create("INVALID"));

Assert.Contains(nameof(ValidationTestSemanticString), ex.Message);
}
}
Loading