Conversation
Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the DocumentDB fan-out of the Postgres cross data center disaster recovery (DC-DR) design. It adds the apimachinery types DocumentDB needs so the operator and coordinator can express distributed multi-DC clusters and report their DR state.
apis/kubedb/v1alpha2/documentdb_types.go
DocumentDBSpec.Distributed bool(jsondistributed). When true, the operator expands the CR into per-DC manifestwork objects instead of raw resources.DocumentDBSpec.PodPlacementPolicy *core.LocalObjectReference(jsonpodPlacementPolicy, defaults to{name:"default"}).DocumentDBStatus.DisasterRecovery *DocumentDBDisasterRecoveryStatus(jsondisasterRecovery), the cross-DC view reflected onto the single Database object.DocumentDBDRPhase(consts Steady, FailingOver, FailingBack, Degraded),DocumentDBDisasterRecoveryStatus(ActiveDC, Phase, DataCenters, LastTransitionTime), andDocumentDBDCStatus(ClusterName, Role, Leader, Writable, LagBytes, Healthy).apis/ops/v1alpha1/documentdb_ops_types.go
DocumentDBHorizontalScalingSpec.DataCenters []DocumentDBHorizontalScalingDC(jsondataCenters), for scaling each DC's local node count independently.DocumentDBHorizontalScalingDC(ClusterName, Replicas).Deepcopy
Hand-edited
zz_generated.deepcopy.goin both packages to match the shapes the Postgres generated funcs use (pointer alloc for LagBytes and LastTransitionTime, range copy for DataCenters, LocalObjectReference and DisasterRecovery pointer deepcopy).Verification
go build ./apis/...andgo vet ./apis/kubedb/v1alpha2/... ./apis/ops/v1alpha1/...both pass.Notes
make gen, sostatus.disasterRecoveryand the new spec fields are not yet in the generated schema.