Add Milvus Addon

[biswasurmi]

Summary by CodeRabbit

• New Features
  • Added KubeStash support for backing up and restoring Milvus databases.
  • Backups can optionally target specific collections.
  • Restored collections can use a configurable name suffix.
  • Added configurable namespace, session, snapshot, and timeout settings for backup and restore operations.

[coderabbitai]

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8a05f044-2903-43c1-9c3c-869a545c94d5

📥 Commits

Reviewing files that changed from the base of the PR and between 85be047 and 38e8e43.

📒 Files selected for processing (7)

• catalog/kubestash/fmt/main.go
• catalog/kubestash/raw/milvus/milvus-backup-function.yaml
• catalog/kubestash/raw/milvus/milvus-restore-function.yaml
• charts/kubedb-kubestash-catalog/templates/milvus/milvus-addon.yaml
• charts/kubedb-kubestash-catalog/templates/milvus/milvus-backup.yaml
• charts/kubedb-kubestash-catalog/templates/milvus/milvus-restore.yaml
• charts/kubedb-kubestash-catalog/values.yaml

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d02b6e09-11eb-4c4f-ac40-10b657b29c3a

📥 Commits

Reviewing files that changed from the base of the PR and between f2e35a1 and 85be047.

📒 Files selected for processing (3)

• catalog/kubestash/raw/milvus/milvus-addon.yaml
• catalog/kubestash/raw/milvus/milvus-backup-function.yaml
• catalog/kubestash/raw/milvus/milvus-restore-function.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The PR adds a KubeStash Milvus addon with singleton Job-based backup and restore tasks. It also adds backup and restore Function resources that invoke the Milvus backup plugin with configurable parameters and defaults.

Changes

Milvus backup and restore

Layer / File(s)	Summary
Milvus plugin functions catalog/kubestash/raw/milvus/milvus-backup-function.yaml, catalog/kubestash/raw/milvus/milvus-restore-function.yaml	Adds milvus-backup and milvus-restore Functions that run the plugin with templated backup and restore parameters.
Addon task wiring catalog/kubestash/raw/milvus/milvus-addon.yaml	Adds singleton Job-based backup and restore tasks with optional collections, restore suffix, defaults, usage descriptions, and function references.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 85be0

The Milvus backup and restore addon is mergeable based on the available evidence, with no concrete merge-blocking risk established.

Sequence Diagram(s)

sequenceDiagram
  participant MilvusAddon
  participant JobExecutor
  participant MilvusFunction
  MilvusAddon->>JobExecutor: create singleton backup or restore Job
  JobExecutor->>MilvusFunction: invoke milvus-backup or milvus-restore
  MilvusFunction->>MilvusFunction: run milvus-backup-plugin

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the primary change: adding a Milvus addon with backup and restore functions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mv-addon

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}