Remove dead operator.etcd.io/etcdclusters RBAC grant

[tamalsaha]

What

Milvus's internal meta-storage etcd cluster is now a KubeDB Etcd database (kubedb.dev/etcd operator, kubedb.com/v1alpha2 Etcd CRD) instead of the official upstream go.etcd.io/etcd-operator's EtcdCluster (kubedb/apimachinery#1897, kubedb/milvus#68).

The etcds.kubedb.com resource this now uses is already covered by the existing kubedb.com wildcard grant (resources: ["*"], verbs: ["*"]) in these same RBAC manifests, so the operator.etcd.io/etcdclusters grant is now dead weight left over from the old integration. Removed it from the three places it was duplicated:

• charts/kubedb-provisioner/templates/cluster-role.yaml (the Helm chart's ClusterRole)
• config/rbac/custom_role.yaml (the kustomize source)
• bundle/manifests/kubedb-installer.clusterserviceversion.yaml (the OLM bundle manifest)

Out of scope

The Milvus CRD schema itself (new spec.metaStorage.tls/spec.metaStorage.authSecret fields) will pick up automatically on the next routine kubedb.dev/apimachinery dependency bump in this repo, once kubedb/apimachinery#1897 is released - no need to hand-sync it here ahead of that.

Testing

Plain YAML edits (removing existing blocks, no reformatting). No installer-specific tests run.

Summary by CodeRabbit

• Chores
  • Removed unused access permissions for etcd cluster resources from the operator’s installation and runtime configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ec630822-d1a7-426a-bf82-2f697ee332d6

📥 Commits

Reviewing files that changed from the base of the PR and between ad2ac8d and dfa3f84.

📒 Files selected for processing (3)

• bundle/manifests/kubedb-installer.clusterserviceversion.yaml
• charts/kubedb-provisioner/templates/cluster-role.yaml
• config/rbac/custom_role.yaml

💤 Files with no reviewable changes (3)

• config/rbac/custom_role.yaml
• bundle/manifests/kubedb-installer.clusterserviceversion.yaml
• charts/kubedb-provisioner/templates/cluster-role.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes operator.etcd.io etcdclusters permissions from the installer CSV, Helm ClusterRole template, and custom ClusterRole.

Changes

RBAC permission removal

Layer / File(s)	Summary
Remove etcdclusters permissions bundle/manifests/kubedb-installer.clusterserviceversion.yaml, charts/kubedb-provisioner/templates/cluster-role.yaml, config/rbac/custom_role.yaml	The three RBAC definitions no longer grant create, delete, get, list, patch, update, or watch permissions on operator.etcd.io etcdclusters resources.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to dfa3f

This change removes obsolete EtcdCluster RBAC permissions consistently across the installer manifests. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the obsolete operator.etcd.io/etcdclusters RBAC grant.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch milvus-etcd

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}