Repository navigation
Add Milvus archiver addon, functions and CRDs - #2454
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (36)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: sabnaj <sabnaj@appscode.com>
…unction, allow reading VolumeSnapshots Signed-off-by: sabnaj <sabnaj@appscode.com>
Signed-off-by: sabnaj <sabnaj@appscode.com>
Signed-off-by: sabnaj <sabnaj@appscode.com>
Sabnaj-42
force-pushed
the
milvus-basebackup&pitr
branch
from
October 9, 2026 06:13
aae0002 to
da37e8f
Compare
Signed-off-by: sabnaj <sabnaj@appscode.com>
Signed-off-by: sabnaj <sabnaj@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milvus addon tasks and functions, MilvusVersion archiver section, regenerated CRDs and cronjobs RBAC for the provisioner role.
Part of the Milvus base backup, VolumeSnapshot backup and PITR work. Merge order: kubedb/apimachinery and kubestash/apimachinery first, then the rest.
Draft because: several repos carry local
replace kubedb.dev/apimachinery => ../apimachinery(and kubestash) lines in go.mod and a vendor/ synced to the unreleased apimachinery. Drop the replaces and re-vendor against the released apimachinery before merging.Tested on a fresh k3s with the real KubeDB and KubeStash operators: full backup and restore (Woodpecker standalone, RocksMQ standalone, distributed), CSI VolumeSnapshot backup, manifest backup/restore, PITR, base selection, retention, fence timeout, sidekick restart, etcd compaction gap, halt/resume. Not run: TLS meta etcd, webhook deployment.
🤖 Generated with Claude Code