Skip to content

Add Milvus archiver addon, functions and CRDs - #2454

Merged
souravbiswassanto merged 7 commits into
masterfrom
milvus-basebackup&pitr
Oct 9, 2026
Merged

souravbiswassanto merged 7 commits into
masterfrom
milvus-basebackup&pitr

Conversation

@Sabnaj-42

Copy link
Copy Markdown
Contributor

Milvus addon tasks and functions, MilvusVersion archiver section, regenerated CRDs and cronjobs RBAC for the provisioner role.

Part of the Milvus base backup, VolumeSnapshot backup and PITR work. Merge order: kubedb/apimachinery and kubestash/apimachinery first, then the rest.

Draft because: several repos carry local replace kubedb.dev/apimachinery => ../apimachinery (and kubestash) lines in go.mod and a vendor/ synced to the unreleased apimachinery. Drop the replaces and re-vendor against the released apimachinery before merging.

Tested on a fresh k3s with the real KubeDB and KubeStash operators: full backup and restore (Woodpecker standalone, RocksMQ standalone, distributed), CSI VolumeSnapshot backup, manifest backup/restore, PITR, base selection, retention, fence timeout, sidekick restart, etcd compaction gap, halt/resume. Not run: TLS meta etcd, webhook deployment.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9faba1e2-a1de-420c-b4a9-7a4b71a836ed
📥 Commits

Reviewing files that changed from the base of the PR and between 2d29e3b and 776177a.

📒 Files selected for processing (36)
  • catalog/copy-images.sh
  • catalog/export-images.sh
  • catalog/imagelist.yaml
  • catalog/import-images.sh
  • catalog/import-into-k3s.sh
  • catalog/kubedb/raw/documentdb/documentdb-0.109.0.yaml
  • catalog/kubedb/raw/milvus/milvus-2.6.11.yaml
  • catalog/kubedb/raw/milvus/milvus-2.6.7.yaml
  • catalog/kubedb/raw/milvus/milvus-2.6.9.yaml
  • catalog/kubestash/raw/milvus/milvus-addon.yaml
  • catalog/kubestash/raw/milvus/milvus-csi-snapshotter-function.yaml
  • catalog/kubestash/raw/milvus/milvus-physical-backup-function.yaml
  • catalog/kubestash/raw/milvus/milvus-physical-backup-restore-function.yaml
  • catalog/scripts/milvus/imagelist.yaml
  • catalog/scripts/operator/copy-images.sh
  • catalog/scripts/operator/export-images.sh
  • catalog/scripts/operator/imagelist.yaml
  • catalog/scripts/operator/import-images.sh
  • catalog/scripts/operator/import-into-k3s.sh
  • charts/kubedb-catalog/crds/catalog.kubedb.com_milvusversions.yaml
  • charts/kubedb-catalog/templates/documentdb/documentdb-0.109.0.yaml
  • charts/kubedb-catalog/templates/milvus/milvus-2.6.11.yaml
  • charts/kubedb-catalog/templates/milvus/milvus-2.6.7.yaml
  • charts/kubedb-catalog/templates/milvus/milvus-2.6.9.yaml
  • charts/kubedb-certified-crds/crds/catalog.kubedb.com_milvusversions.yaml
  • charts/kubedb-crds/crds/archiver.kubedb.com_milvusarchivers.yaml
  • charts/kubedb-crds/crds/catalog.kubedb.com_milvusversions.yaml
  • charts/kubedb-crds/crds/gitops.kubedb.com_milvuses.yaml
  • charts/kubedb-crds/crds/kubedb.com_milvuses.yaml
  • charts/kubedb-kubestash-catalog/templates/documentdb/documentdb-addon.yaml
  • charts/kubedb-kubestash-catalog/templates/milvus/milvus-addon.yaml
  • charts/kubedb-kubestash-catalog/templates/milvus/milvus-csi-snapshotter.yaml
  • charts/kubedb-kubestash-catalog/templates/milvus/milvus-physical-backup-restore.yaml
  • charts/kubedb-kubestash-catalog/templates/milvus/milvus-physical-backup.yaml
  • charts/kubedb-provisioner/README.md
  • charts/kubedb-provisioner/templates/cluster-role.yaml
 ______________________________________________________________________
< Your indentation suggests confidence. Your logic suggests otherwise. >
 ----------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: sabnaj <sabnaj@appscode.com>
…unction, allow reading VolumeSnapshots

Signed-off-by: sabnaj <sabnaj@appscode.com>
Signed-off-by: sabnaj <sabnaj@appscode.com>
Signed-off-by: sabnaj <sabnaj@appscode.com>
@Sabnaj-42
Sabnaj-42 force-pushed the milvus-basebackup&pitr branch from aae0002 to da37e8f Compare October 9, 2026 06:13
@souravbiswassanto
souravbiswassanto marked this pull request as ready for review October 9, 2026 07:43
@souravbiswassanto
souravbiswassanto merged commit a72c036 into master Oct 9, 2026
6 of 8 checks passed
@souravbiswassanto
souravbiswassanto deleted the milvus-basebackup&pitr branch October 9, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants