Repository navigation
courier: allow deleting PetSets for Branch refresh - #2462
Conversation
Signed-off-by: Rabbani Islam Refat <refat@appscode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Courier agent roles in two charts now grant ChangesCourier PetSet RBAC
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established in the changed permissions. The cleanup method and marker parity remain unverified, but neither currently demonstrates a reason to block merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Courier Branch refresh now pauses the target Database via the
Pausedstatus condition and deletes its PetSets before re-cloning PVCs (kubedb/courier, branchbranch-refresh-pause).charts/kubedb-courier/templates/rbac.yaml: get/list/watch/delete onapps.k8s.appscode.competsets.charts/kubedb-courier-addon-manager/templates/addontemplate.yaml: same rule for the courier-agent on managed clusters.Pods (get/list/watch) and
kubedb.com/statuswrite access were already granted in both places.Summary by CodeRabbit