Skip to content

courier: allow deleting PetSets for Branch refresh - #2462

Merged
souravbiswassanto merged 1 commit into
masterfrom
courier-petset-rbac
Oct 8, 2026
Merged

souravbiswassanto merged 1 commit into
masterfrom
courier-petset-rbac

Conversation

@refat75

@refat75 refat75 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Courier Branch refresh now pauses the target Database via the Paused status condition and deletes its PetSets before re-cloning PVCs (kubedb/courier, branch branch-refresh-pause).

  • charts/kubedb-courier/templates/rbac.yaml: get/list/watch/delete on apps.k8s.appscode.com petsets.
  • charts/kubedb-courier-addon-manager/templates/addontemplate.yaml: same rule for the courier-agent on managed clusters.

Pods (get/list/watch) and kubedb.com /status write access were already granted in both places.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Branch refresh failures involving PetSet deletion by updating the agent’s access permissions.

Signed-off-by: Rabbani Islam Refat <refat@appscode.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bbfe8b1-4fb4-40d9-b55a-2f2e60eea0db
📥 Commits

Reviewing files that changed from the base of the PR and between 284c4bd and 60d52ff.

📒 Files selected for processing (2)
  • charts/kubedb-courier-addon-manager/templates/addontemplate.yaml
  • charts/kubedb-courier/templates/rbac.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Courier agent roles in two charts now grant get, list, watch, and delete access to petsets in the apps.k8s.appscode.com API group.

Changes

Courier PetSet RBAC

Layer / File(s) Summary
Add PetSet permissions
charts/kubedb-courier-addon-manager/templates/addontemplate.yaml, charts/kubedb-courier/templates/rbac.yaml
Both roles grant get, list, watch, and delete access to petsets in apps.k8s.appscode.com.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: tamalsaha

Merge Risk: ⚪ Minimal · up to 60d52

No actionable issue is established in the changed permissions. The cleanup method and marker parity remain unverified, but neither currently demonstrates a reason to block merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: granting permission to delete PetSets for Branch refresh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@souravbiswassanto
souravbiswassanto merged commit 2d29e3b into master Oct 8, 2026
7 of 8 checks passed
@souravbiswassanto
souravbiswassanto deleted the courier-petset-rbac branch October 8, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants