Skip to content

Support proxyRef fallback when generating ops request name #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 1 commit into from
Jul 9, 2026
Merged

Support proxyRef fallback when generating ops request name #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/controllers/supervisor/recommendation_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,16 +333,22 @@ func (r *RecommendationReconciler) runMaintenanceWork(ctx context.Context, rcmd
}

func generateOpsRequestName(unObj *unstructured.Unstructured) (string, error) {
dbName, found, err := unstructured.NestedString(unObj.Object, "spec", "databaseRef", "name")
refName, found, err := unstructured.NestedString(unObj.Object, "spec", "databaseRef", "name")
if err != nil {
return "", err
}
if !found {
return "", fmt.Errorf("invalid recommendation %s; missing `spec.databaseRef.name` in spec.opration", unObj.GetName())
refName, found, err = unstructured.NestedString(unObj.Object, "spec", "proxyRef", "name")
if err != nil {
return "", err
}
if !found {
return "", fmt.Errorf("invalid recommendation %s; missing `spec.databaseRef.name` or `spec.proxyRef.name` in spec.opration", unObj.GetName())
}
}
unixTime := time.Now().Unix()
operationType := unObj.GetName()
return meta_util.ValidNameWithPrefix(dbName, fmt.Sprintf("%v-%s-auto", unixTime, operationType)), nil
return meta_util.ValidNameWithPrefix(refName, fmt.Sprintf("%v-%s-auto", unixTime, operationType)), nil
}

func (r *RecommendationReconciler) handleErr(ctx context.Context, rcmd *api.Recommendation, err error, phase api.RecommendationPhase) (ctrl.Result, error) {
Expand Down
Loading