Fix informer initial list items missing kind/apiVersion#4734
Draft
Fix informer initial list items missing kind/apiVersion#4734
Conversation
…om list metadata or ModelMapper Agent-Logs-Url: https://github.com/kubernetes-client/java/sessions/717d58ee-9dd8-47b6-ba67-22c111fcaa80 Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Agent-Logs-Url: https://github.com/kubernetes-client/java/sessions/717d58ee-9dd8-47b6-ba67-22c111fcaa80 Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix initial list items missing kind and apiVersion in Pod objects
Fix informer initial list items missing kind/apiVersion
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes API omits
kind/apiVersionfrom individual items in list responses (they're set on the list object itself), but includes them in watch events. This causedReflectorRunnable's initial list phase to produce items withnulltype metadata, while subsequent watch events would have them populated — an inconsistency that breaks any code relying on these fields being consistently set.Changes
ReflectorRunnable: After fetching the initial list, calls newpopulateTypeMeta()to backfillkind/apiVersionon items that are missing them."List"suffix from the list'skind(e.g.PodList→Pod) and uses the list'sapiVersiondirectly.ModelMapper.getGroupVersionKindByClass()/preBuiltGetGroupVersionKindByClass()when the list object itself has no type metadata (e.g. in tests).setKind/setApiVersionMethodreferences are cached in the constructor (one-time reflection lookup perReflectorRunnableinstance) to avoid per-call overhead.ReflectorRunnableTest: Added 4 tests covering the primary path, ModelMapper fallback, no-overwrite of existing values, and end-to-end population through the full list flow.