Repository navigation
Tolerate json/v2 invalid UTF-8 munging in YAMLToJSON tests - #141
Open
arthurbdiniz wants to merge 1 commit into
Open
arthurbdiniz wants to merge 1 commit into
arthurbdiniz wants to merge 1 commit into
Conversation
Signed-off-by: Arthur Diniz <arthurbd@debian.org>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arthurbdiniz, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
TestYAMLToJSON'sbinary datacase decodes an invalid UTF-8 payload via a!!binarytag and asserts that the resulting JSON escapes the Unicode replacement character as\ufffd:Go 1.27 reimplements
encoding/jsonon top ofencoding/json/v2. When marshaling a string containing invalid UTF-8 (which decoding!!binary gIGCproduces), the standard library now emits the replacement character U+FFFD as raw UTF-8 bytes instead of the\ufffdescape sequence. As a result the test fails on Go 1.27 while passing on Go 1.26 and earlier.This PR adds a
jsonAllowfield to the test case struct that lists accepted alternate JSON representations, and tolerates the raw-UTF-8 form for thebinary datacase. The canonical\ufffdexpectation is preserved for every other case, so the byte-exact assertion is unchanged elsewhere. This is a test-only change; there is no change to library behavior.How to reproduce
Using a Go 1.27 toolchain against the current
master:Output before this change:
The same command passes on Go 1.24 through Go 1.26, because their
encoding/jsonstill emits the\ufffdescape.Prior work
Kubernetes made the equivalent change in
k8s.io/apimachinerywhen adapting to json/v2, using the same "tolerate alternate representation" approach:That PR added an
allow []stringfield to the affected test-case struct and accepted the raw-UTF-8 form for the invalid-UTF-8 cases. This PR mirrors that approach forsigs.k8s.io/yaml.