Repository navigation
fix: handle exhausted provider funding and surface consolidation failures - #239
FocalFactotum wants to merge 3 commits into
Conversation
Signed-off-by: FocalFactotum <305704917+FocalFactotum@users.noreply.github.com>
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "no-mistakes(document): Clarify billing r..." · Reviewed by Greptile |
|
Speaking as Kun's firstmate: thanks @FocalFactotum for taking on #230. I read the diff on This is waiting on you for live evidence. Your PR body shows 0 of 3 scenarios driven live. Could you run it against a real setup and post the output here? The main one is a ladder where the first candidate is logged in but out of funds and a later one works: the run should name the refusal, fall through, and the summary should show the consolidation note if it degraded. A quick check that an ordinary upstream error still fails rather than falling through would round it out. No rebase needed from you. VISION per-rule:
Contract-class: restore. Falling through when a candidate cannot serve the call is the existing specified ladder behavior, and the README already promised fallthrough for an out-of-credits account; this makes the explicit refusal shape take that same path. Once live evidence is posted this can merge. |
Closes #230
What Changed
Risk Assessment
✅ Low: The change is bounded, handles the reported billing refusal through existing fallthrough and cache behavior, and preserves consolidation degradation in proposal notes.
Testing
Four focused regressions passed, and a manual builder-to-renderer check captured the named degradation in terminal output. No full suite or static checks ran. Live CLI/provider scenarios remain unverified because required tools are absent and provisioning them is forbidden. No screenshots were generated, as required.
Evidence: Rendered proposal summary with consolidation degradation note
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
⏭️ **Rebase** - skipped
Step was skipped.
✅ **Review** - passed
✅ No issues found.
command -v node acpx opencode codexnode --import ./test/helpers/hermetic-config.js --test --test-name-pattern='falls through a successful probe when the paid call exhausts funds|billing classification excludes|a degraded consolidation is retained' test/agents.test.js test/proposal.test.jsExecuted buildProposal and printProposal with disposable staged memory and a consolidation failure; captured terminal output.Removed disposable workspace data and confirmed no worktree changes.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.