Add the app-shell archetype + reveal/loading defaults (v0.6.0) - #55
Merged
Conversation
First-class support for the most common prototype shape, plus two motion/loading defaults that were being left on the table. - build.md: app-shell documented as the baseline archetype (top bar + rail + inner-scrolling main + pinned footer), with the two gotchas — 390px top-bar overflow (rule 37) and control-bar clearance. - styles.css: `.proto-app-shell` helper + `--proto-controls-safe` token, so a pinned composer/footer never hides under the floating control bar (the collision the agent-console dogfood surfaced). vh→dvh fallback. - Scroll-reveals are now a default for brand/expressive landings (build.md). - Loading control auto-hides when there's nothing to replay (loading.js + UI.hasLoaders()) — no skeleton region and no registered loader → hide it instead of sitting inert. Verified: visible on the console, hidden on Runs/Settings. SKILL.md untouched (2598/2600). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-class support for the most common prototype shape (tools, consoles, dashboards), plus two motion/loading defaults — all surfaced by dogfooding the agent-console build.
App-shell archetype
build.md— app-shell is now a documented baseline archetype: top bar + optional rail + inner-scrolling main + pinned footer/composer, with the two gotchas that break it (390px top-bar overflow → rule 37; control-bar clearance).styles.css— a.proto-app-shellhelper (full-100dvhflex column) + a--proto-controls-safetoken, so a pinned composer/footer never hides under the floating control bar. This is the exact collision the console build hit.Motion / loading defaults
.revealon major sections so the page animates in; a static-scrolling landing reads as unfinished for that register.loading.js+UI.hasLoaders()) — no[data-skeleton-on-load]region and no registered loader → the ⟳ Replay + Speed control hides itself instead of sitting inert. Re-shows if a loader registers later.Verified
🤖 Generated with Claude Code