astromartini@2.1.13: Some tests are not thread safe

[Hellseher]

Hi,

During preparing Guix Astro Update 2025/12 I've noticed that astromartini@2.1.13 sometimes fails on 4 tests, posibly not thread save or not deterministic:

Log tail:

=========================== short test summary info ============================
FAILED tests/test_martini.py::TestMartiniWithDataCubeFromWCS::test_source_insertion[WALLABY_PILOT_CUTOUT_APPROX.HEADER-hdf5] - KeyError: 'Unable to synchronously open object (bad symbol table node signature)'
FAILED tests/test_martini.py::TestMartiniWithDataCubeFromWCS::test_source_insertion[IC_2574_NA_CUBE_THINGS.HEADER-hdf5] - BlockingIOError: [Errno 11] Unable to synchronously create file (unable to lock file, errno = 11, error message = 'Resource temporarily unavailable')
FAILED tests/test_martini.py::TestMartiniWithDataCubeFromWCS::test_source_insertion[comb_10tracks_J1337_28_HI_r10_t90_mg095_2.image.header.permuted-hdf5] - BlockingIOError: [Errno 11] Unable to synchronously create file (unable to lock file, errno = 11, error message = 'Resource temporarily unavailable')
FAILED tests/test_martini.py::TestMartiniWithDataCubeFromWCS::test_source_insertion[comb_10tracks_J1337_28_HI_r10_t90_mg095_2.image.header-hdf5] - FileNotFoundError: [Errno 2] Unable to synchronously open file (unable to open file: name = 'cube.hdf5', errno = 2, error message = 'No such file or directory', flags = 0, o_flags = 0)
======= 4 failed, 2525 passed, 11 skipped, 4 xfailed in 96.13s (0:01:36) =======

Reproducer:

guix time-machine --branch=astro-update -- build python-astromartini

Inputs:
CPU: AMD Ryzen 7 3800X
Python: 3.11.11
Pytest options: --numprocess=8

• python-pytest@8.4.1
• python-pytest-xdist@3.8.0
• python-setuptools@80.9.0
• python-astropy@7.1.1
• python-numpy@1.26.4
• python-scipy@1.12.0
• python-tqdm@4.67.1
• python-gizmo-analysis@1.0.4
• python-h5py@3.13.0
• python-requests@2.32.5
• python-swiftgalaxy@1.2.1
• python-swiftsimio@9.0.1
• python-utilities-awetzel@1.0.3

Complete build log:

lii08f3mv3in3a7v41xjax91ggdbxw-python-astromartini-2.1.13.drv.gz

[kyleaoman]

Thanks for reporting! The martini tests are definitely not safe to run with pytest-xdist, please run serially. Making them safe to run concurrently is on the to-do list. I've done it for another package that I maintain recently, so am confident that I can do it without much difficulty, just need to carve out time for it.