Skip to content

Add cine reader#61

Open
ThijsIllimited wants to merge 4 commits into
ladisk:masterfrom
ThijsIllimited:add-cine-reader
Open

Add cine reader#61
ThijsIllimited wants to merge 4 commits into
ladisk:masterfrom
ThijsIllimited:add-cine-reader

Conversation

@ThijsIllimited

Copy link
Copy Markdown
Collaborator

Hi all,

We use a Phantom high-speed camera here in Twente, which records in Phantom's native .cine format. I have implemented .cine format support for VideoReader that I believe might be useful to others.

Implementation Details

  • Optional Dependency: Integrates cine-reader as an optional dependency (extras_require={'cine': ['cine-handler']}).
  • Lazy Loading: cine-reader is imported lazily inside VideoReader only when opening a file with a .cine extension. Non-.cine users will not be affected and do not need to install additional dependencies.
  • Testing: Added test_get_frames_cine(), which uses pytest.importorskip("cine_reader") so the test suite skips cleanly if cine-reader is not installed on the test runner.
  • Documentation: Updated README.md with instructions on installing pyidi[cine].

Let me know what you think, I will make updates accordingly.

Best regards,
Thijs

@jankoslavic
jankoslavic requested a review from itomac July 25, 2026 07:33
@jankoslavic

Copy link
Copy Markdown
Contributor

@ThijsIllimited great PR. I have asked @itomac for review. @klemengit is do you confirm it?

@ThijsIllimited

Copy link
Copy Markdown
Collaborator Author

fyi made a small edit. It now sets keep_annotations to false for less I/O reads. Also, the recommended pip install was cine-handler not cine-reader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants