[13.x] Add without-migration-data flag to DumpCommand#60570
Open
jackbayliss wants to merge 3 commits into
Open
[13.x] Add without-migration-data flag to DumpCommand#60570jackbayliss wants to merge 3 commits into
without-migration-data flag to DumpCommand#60570jackbayliss wants to merge 3 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
without-migration-data to DumpCommandwithout-migration-data flag to DumpCommand
Contributor
|
What about |
Contributor
Author
|
@shaedrich Any work for me tbh, depends on Taylor what he prefers 😄 as long as I can opt out is the main thing :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
--without-migration-dataflag toschema:dumpthat skips appending the migration rows, so the dump becomes pure structure.ie...
We use this the dump command a lot internally for dumping the schema for our tests (as the docs suggest), as well as various commands for our feature flags etc to ensure the schema is always updated when something is released.
At the moment we end up truncating the migration table using DB before we call dump to ensure its not appended, which feels less magic / painful.
it would be nice to just have the ability to opt out hence the PR which I've tried to keep dead simple but you may see a nicer way? 😎