Add South Korea Constitution Day (from 2026) and June 2026 election holiday - #2685
Open
PureSaber wants to merge 1 commit into
Open
Add South Korea Constitution Day (from 2026) and June 2026 election holiday#2685PureSaber wants to merge 1 commit into
PureSaber wants to merge 1 commit into
Conversation
…oliday. Constitution Day was reinstated as a public holiday in 2026 and KRX closed on both July 17 and local election day June 3; update calendar and tests. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
|
Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it. |
Owner
|
Thanks for contributing! May you check the CLAassistant comment above? |
Owner
|
More tests need updating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-suite/calendars.cpp.KRX closed securities/derivatives markets on both dates after the government reinstated Constitution Day and designated local election day as a public holiday.
Test plan
testSouthKoreanSettlement/ KRX calendar testsSouthKoreatreats 2026-06-03 and 2026-07-17 as holidays; 2008-07-17 remains a business day (weekday between 2008 and 2025).