Smart block deconstruction#1170
Merged
Merged
Conversation
Address review feedback on the source-based deconstruction change: - Guard the head-state lookup with a None check and early return, matching the parent-state guard, so a pruned head state no longer raises during block import. - Type the participant union set as set[ValidatorIndex]. - Correct the source-filter rationale comment: a future block on this head can only pack votes anchored on this head's justified checkpoint; older-source votes can no longer advance justification and are dropped. - Fix the stale test comment that claimed deconstruction runs for every processed block; it now runs only for a synced aggregator. - Assert the recovered aggregate as a whole object instead of piecewise. - Add process_block coverage for the synced-aggregator gate across its three outcomes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tcoratger
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
We were doing naive deconstruction of all the blocks that were being imported, instead we can only focus on attestations that can have source as state's latest justified as those can be packed to move chain's justified and finalized ahead.
🔗 Related Issues or PRs
✅ Checklist
just check