Fix missing dependencies, CLI convention and convert to pyproject.toml - #23
Merged
Conversation
added 4 commits
March 20, 2025 20:05
Changed license to https://spdx.org/licenses/BSD-3-Clause.html Dropped classifier "License :: OSI Approved :: BSD License" `requirements.txt` cannot be merged as it still is used by: - .readthedocs.yml - .devcontainer/Dockerfile - .devcontainer/devcontainer.json What is `snooty`? Signed-off-by: Philipp Hahn <p.hahn@avm.de>
Dependency was missing. Depend on `packaging` for version comparison. Signed-off-by: Philipp Hahn <p.hahn@avm.de> Closes: leifwalsh#20
Dependency was missing. Replace with `importlib.resources` available since Python 3.7. Signed-off-by: Philipp Hahn <p.hahn@avm.de> Closes: leifwalsh#20
Require at least one argument for command:
```console
$ flametrace
Traceback (most recent call last):
File "…/bin/flametrace", line 10, in <module>
sys.exit(cli())
^^^^^
File "…/lib/python3.11/site-packages/click/core.py", line 1161, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "…/lib/python3.11/site-packages/click/core.py", line 1082, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "…/lib/python3.11/site-packages/click/core.py", line 1443, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "…/lib/python3.11/site-packages/click/core.py", line 788, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "…/src/flametrace/main.py", line 112, in cli
argv0 = os.path.basename(command[0])
~~~~~~~^^^
IndexError: tuple index out of range
```
See <https://click.palletsprojects.com/en/stable/arguments/>.
Signed-off-by: Philipp Hahn <p.hahn@avm.de>
Closes: leifwalsh#21
leifwalsh
approved these changes
Jun 6, 2026
leifwalsh
left a comment
leifwalsh
left a comment
Owner
There was a problem hiding this comment.
Oh gosh I didn't notice this. Thank you very much! Sorry it took so long to merge.
Owner
|
hmm, gotta fix CI too |
Python 3.7-9 have reached their End-of-life years ago. Remove them. Instead add 3.10-14. See <https://devguide.python.org/versions>. Signed-off-by: Philipp Matthias Hahn <pmhahn@pmhahn.de>
Author
See https://devguide.python.org/versions/: All versions of Python 3.7-9 mentioned in |
Python 3.8 has reached its End-of-life a year ago. Switch to 3.14. See <https://docs.readthedocs.com/platform/stable/config-file/v2.html> Signed-off-by: Philipp Matthias Hahn <pmhahn@pmhahn.de>
There is no package available by such name on pypi.org. Drop it. Signed-off-by: Philipp Matthias Hahn <pmhahn@pmhahn.de>
leifwalsh
approved these changes
Jun 7, 2026
leifwalsh
enabled auto-merge
June 7, 2026 17:49
Owner
|
such a pile of yaks had moved in |
Owner
|
Ok, I can't reproduce that failure in codespaces. I need to put this down for a bit and come back to it, but we're a lot closer. |
leifwalsh
disabled auto-merge
June 29, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have it a try today and immediately run into 3 ploblems: #20 #21 #22
The first 2 #20 and #21 I was able to fix.
Bonus: convert
setup.*topyproject.toml