Conversation
254808127
marked this pull request as ready for review
September 20, 2026 08:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the browser-use dependency from
b174da3fcd1c6483fbae9746cbc686fb97b502a5to540eef7c85d1165b54554e1faf174faf4189dd93to pick up the reviewed download OOM fix from 254808127/browser-use#1.The new pin merges the fork's reviewed
main(ed8eef39a9a14e79fb1f20706a2dd563b97276bd) into the existing integration branch. This preserves the session/OOPIF fixes already present in the old pin; pointing directly at fork main would drop those fixes. Git ancestry and equality of the download implementation/tests against merged fork main were verified.Both automatic download paths now read browser Blobs in bounded 256 KiB CDP chunks, without serializing a whole-file JavaScript number array. The reviewed version also finishes cancellation-safe resource cleanup before publishing the destination file.
This PR changes one dependency line. The locally updated
uv.lockremains ignored under the repository's existing policy.Contribution type
Reproduction or validation
uv sync --extra dev --extra browser-useuv run pytest tests/: 840 passed, 2 skipped, 59.48 seconds.uv lock --checkandgit diff --check: passed.Real smoke command (runtime YAML supplies existing environment-variable credentials):
The Agent ran against a real remote browser; task 5 completed in 124.4 seconds:
The original S2 Online-Mind2Web task also completed using the same pinned revision and real Lexmount backend:
https://www.mta.info/document/10341: 24,865,690 bytes.2a036ad51d4c04ba6784a1f9f280c2637f1d9794af154513b920f1bf60b5b07e, matching the original reproduction PDF.Self-review (mandatory)
/code-reviewand fixed or justified every finding.uv run pytest tests/passes; targeted behavior coverage is in the pinned fork.Notes for reviewers
Draft because the required local Claude review is unavailable. Attempted the prescribed
claude -p "/code-review ..."and explicit-model retries. Each returned an unavailable-model error (claude-opus-4.8/claude-opus-4-8[1m]) before producing a review. The checkbox is intentionally left unticked; manual diff review, tests, and real smoke execution are complete. The required local automated review remains to be run when the configured service is available.Initial validation setup failures were resolved by installing the agent extra and exporting
uvon PATH. The clean base also lowercases runtime configuration keys while its CDP backend only readsCDP_ADDRESS, causing external-CDP setup to fall back to localhost:9222. The successful smoke uses the existing Lexmount backend; this PR does not include that separate CDP configuration fix or pre-existing local provider edits.