Skip to content

fix(indexeddb): finish upgrade opens after transaction completion - #427

Open
ldm0 wants to merge 1 commit into
mainfrom
fix/indexeddb-upgrade-order
Open

fix(indexeddb): finish upgrade opens after transaction completion#427
ldm0 wants to merge 1 commit into
mainfrom
fix/indexeddb-upgrade-order

Conversation

@ldm0

@ldm0 ldm0 commented Sep 7, 2026

Copy link
Copy Markdown
Member

Dependency / merge order

Stacked on #426 (fix/svg-create-rect) so this PR contains exactly one IndexedDB commit. The dependency is the combined SVG-gated application-startup smoke, not the IndexedDB implementation. Merge #426 first, then rebase this commit onto main and retarget this PR; if #426 is squash-merged, do not merge the old SVG commit a second time.

Summary

  • Keep the exact open request attached to the upgrade transaction until accepted requests and their microtasks finish.
  • Publish open success/error in a separate task after transaction completion; cover abort rollback and a connection closed before result delivery.
  • Preserve FIFO among waiting open/delete requests for the same database and remove eager/duplicate lifecycle paths.
  • Preserve task-boundary, migration, microtask, rollback, deletion-order, and combined application-startup regressions. The standalone SVGRect contract lives in fix(svg): expose detached SVGRect values #426.

Validation

  • Local: cargo fmt --all and git diff --check passed.
  • Per request, Clippy, nextest, and runtime smoke are left to CI; they were not rerun locally for this split.

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Spider Bench A/B

✅ All benchmark browser service runs completed; results are informational.

Public HEAD: 184 / 240 rows; 38 / 48 sites produced rows; 10 unexpected empty sites.

✅ Deterministic fixture contract is clean.

Common ancestor 761e9d011bd9 → HEAD 5f491b63df66; benchmark order: head-first; workflow: success.

Public 48-site run · informational

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 184 / 240 184 / 240 0 (0.00%)
Contract fill 76.67% 76.67% 0.00 pp (0.00%)
Sites with rows 38 / 48 38 / 48 0 (0.00%)
Sites meeting row contract 36 / 48 36 / 48 0 (0.00%)
Unexpected empty sites 10 10 0 (0.00%)
Partial-row sites 2 2 0 (0.00%)
Site outcomes extracted: 37; HTTP error + rows: 1; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 extracted: 36; HTTP error + rows: 2; empty: 7; HTTP error + empty: 1; snapshot error + empty: 2 —
Observed duration 47.63 s 45.91 s -1.72 s (-3.61%)
Estimated CPU 45.19 s 44.42 s -0.77 s (-1.69%)
Peak PSS 199.84 MiB 198.02 MiB -1.83 MiB (-0.91%)
Peak RSS 203.65 MiB 200.95 MiB -2.70 MiB (-1.33%)
Peak threads 27 26 -1 (-3.70%)
Mismatched sites 0 0 0
Timeout with items 0 0 0
Category rows Base HEAD Δ
news 35 / 40 35 / 40 0
stocks 20 / 40 20 / 40 0
tech 35 / 40 35 / 40 0
sports 27 / 40 27 / 40 0
games 37 / 40 37 / 40 0
life 30 / 40 30 / 40 0

Public-site content, timing, and memory are noisy. This single A/B run reports evidence only; site outcome counts explain missing rows without treating them as a deterministic regression.

CPU and memory timelines

These are bounded 40-point views of the same complete process-tree samples used by the HTML report. CPU uses 100% per occupied logical core; memory lines are RSS first and PSS second when complete PSS samples are available.

Base

xychart-beta
    title "Base CPU"
    x-axis "Elapsed seconds" [1.04, 1.542, 2.542, 4.043, 5.546, 6.547, 8.049, 9.551, 10.551, 12.053, 13.555, 14.557, 16.059, 17.561, 18.562, 20.065, 21.567, 22.568, 24.069, 25.571, 26.572, 28.074, 28.574, 29.575, 30.576, 32.078, 33.579, 34.579, 36.081, 37.583, 38.583, 40.084, 41.585, 42.586, 44.087, 45.589, 46.59, 47.09]
    y-axis "CPU percent" 0 --> 500
    line [61.96, 123.67, 139.87, 125.95, 165.91, 135.7, 167.8, 111.97, 105.93, 125.94, 105.78, 5.99, 31.98, 77.98, 121.76, 6, 23.94, 0, 139.9, 123.87, 117.67, 143.84, 124.06, 143.77, 67.94, 135.79, 27.98, 39.99, 111.93, 73.96, 130.04, 62.02, 0, 111.89, 124.07, 101.93, 111.89, 211.77]
Loading 
xychart-beta
    title "Base memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.04, 1.04, 1.542, 2.542, 4.043, 5.546, 6.547, 8.049, 9.551, 10.551, 12.053, 13.555, 14.557, 16.059, 17.561, 18.562, 20.065, 21.567, 22.568, 24.069, 25.571, 26.572, 28.074, 28.574, 29.575, 30.576, 32.078, 33.579, 34.579, 36.081, 37.583, 38.583, 40.084, 41.585, 42.586, 44.087, 45.589, 46.59, 47.09, 47.631]
    y-axis "Memory MiB" 0 --> 500
    line [12.34, 90.25, 107.32, 113.6, 144.31, 184.66, 161.08, 181.08, 162.15, 179.59, 160.45, 154.73, 152.57, 203.15, 160.83, 153.34, 149.16, 141.26, 137.2, 176.43, 165.24, 176.32, 190.5, 203.65, 177.69, 166.02, 170.2, 147.67, 148.66, 149.42, 156.64, 176.43, 175.71, 154.56, 172.2, 167.49, 163.48, 178.41, 200.93, 0]
    line [8.95, 86.59, 103.47, 109.84, 140.48, 181.38, 157.26, 177.2, 158.33, 175.83, 156.63, 150.91, 148.75, 198.58, 157, 149.52, 145.69, 137.43, 133.37, 172.66, 161.44, 172.49, 186.67, 199.84, 173.86, 162.2, 166.36, 143.84, 144.83, 145.59, 152.81, 172.61, 171.88, 150.74, 168.37, 163.67, 159.69, 174.54, 197.2, 0]
Loading

HEAD

xychart-beta
    title "HEAD CPU"
    x-axis "Elapsed seconds" [1.036, 1.536, 2.538, 3.538, 4.038, 4.538, 5.54, 6.542, 8.044, 9.046, 10.547, 12.048, 13.05, 14.051, 14.552, 16.054, 17.054, 18.554, 19.556, 21.059, 22.563, 23.563, 25.065, 26.567, 27.568, 29.071, 30.072, 31.574, 33.074, 34.075, 35.577, 37.08, 38.081, 39.583, 40.584, 42.086, 43.588, 44.59]
    y-axis "CPU percent" 0 --> 500
    line [63.82, 133.76, 133.78, 116.02, 120.05, 183.74, 233.64, 139.65, 131.82, 137.88, 87.96, 111.9, 121.72, 0, 3.99, 6, 0, 84, 87.8, 25.95, 141.63, 95.91, 149.97, 145.85, 101.91, 131.89, 131.82, 145.79, 23.96, 107.88, 5.99, 137.79, 49.96, 5.98, 69.96, 117.89, 67.93, 121.92]
Loading 
xychart-beta
    title "HEAD memory: RSS then PSS"
    x-axis "Elapsed seconds" [0.034, 1.036, 1.536, 2.538, 3.538, 4.038, 4.538, 5.54, 6.542, 8.044, 9.046, 10.547, 12.048, 13.05, 14.051, 14.552, 16.054, 17.054, 18.554, 19.556, 21.059, 22.563, 23.563, 25.065, 26.567, 27.568, 29.071, 30.072, 31.574, 33.074, 34.075, 35.577, 37.08, 38.081, 39.583, 40.584, 42.086, 43.588, 44.59, 45.91]
    y-axis "Memory MiB" 0 --> 500
    line [12.39, 90.34, 110.89, 116.31, 136.86, 150.83, 172.26, 165.65, 190.24, 153.04, 176.92, 164.49, 163.82, 167.51, 152.64, 130.85, 135.13, 135.13, 142.95, 143.61, 137.91, 175.87, 151.24, 156.1, 185.55, 200.83, 167.53, 172.42, 176.5, 145.77, 144.89, 154.22, 200.95, 170.36, 158.75, 167.35, 165.69, 157.97, 167.39, 0]
    line [8.95, 86.57, 107.12, 112.66, 133.09, 147.17, 168.33, 162.12, 186.57, 150.55, 173.16, 160.68, 160.04, 163.7, 148.83, 127.04, 131.32, 131.32, 138.43, 139.9, 134.1, 172.26, 146.96, 152.3, 181.74, 198.02, 163.71, 168.61, 172.73, 141.96, 141.08, 150.43, 196.18, 166.53, 154.94, 163.54, 161.9, 154.16, 163.62, 0]
Loading

Deterministic fixture · required contract

The fixture exercises 15 routes: 8 are expected to emit rows and 7 intentionally exercise empty, loading, or timeout behavior.

Metric Base HEAD Δ
Run status success success —
Extracted rows / contract 40 / 40 40 / 40 0 (0.00%)
Contract fill 100.00% 100.00% 0.00 pp (0.00%)
Sites with rows 8 / 15 8 / 15 0 (0.00%)
Sites meeting row contract 15 / 15 15 / 15 0 (0.00%)
Unexpected empty sites 0 0 0
Partial-row sites 0 0 0
Site outcomes extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 extracted: 7; HTTP error + rows: 1; empty: 3; timeout + empty: 4 —
Observed duration 19.88 s 19.88 s +0.01 s (+0.04%)
Estimated CPU 0.42 s 0.43 s +0.01 s (+2.38%)
Peak PSS 57.44 MiB 57.20 MiB -0.24 MiB (-0.41%)
Peak RSS 60.75 MiB 60.86 MiB +0.10 MiB (+0.17%)
Peak threads 18 19 +1 (+5.56%)
Mismatched sites 0 0 0
Timeout with items 0 0 0

Full HTML, JSON, CSV, logs, and page snapshots: workflow run and full spider-bench-results artifact.

The public-web A/B is informational. The exact HEAD fixture contract runs as a separate required CI check; timing and public-site content deltas remain non-blocking.

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Sequential Navigation Soak A/B

✅ HEAD completed the 200-navigation resilience and memory observation.

One browser process, one target, and one CDP session navigate CSDN → SegmentFault → Huaban → example.com repeatedly. This run issued 200 Page.navigate commands per binary.

Common ancestor 761e9d011b → HEAD 5f491b63df; benchmark order: head-first; workflow: success.

Session resilience

Metric Base HEAD
Attempted / planned 200 / 200 200 / 200
Direct observable pass 200 / 200 200 / 200
Failures / recovered 0 / 0 0 / 0
Recovery failures 0 0
Lifecycle order violations 0 0
Network order violations 0 0
Wall time 329.7 s 285.6 s

A public-page failure is reported separately from an unrecoverable session. The soak requires all navigation attempts, zero failed recovery, zero lifecycle/network ordering violations, and complete resource evidence.

Process-tree memory

Metric Base HEAD Δ
Boundary samples 200 200 0
Boundary RSS samples 200 200 0
Boundary PSS samples 200 200 0
Periodic peak RSS 212.6 MiB 239.6 MiB +27.0 MiB
Periodic peak PSS 207.9 MiB 236.0 MiB +28.1 MiB
RSS · first 10 avg 165.6 MiB 153.1 MiB -12.5 MiB
RSS · last 10 avg 163.0 MiB 162.8 MiB -0.2 MiB
RSS · last − first window -2.6 MiB +9.7 MiB +12.3 MiB
RSS · warm slope / 100 nav +0.3 MiB +1.3 MiB +1.0 MiB
PSS · first 10 avg 162.6 MiB 149.6 MiB -13.0 MiB
PSS · last 10 avg 159.9 MiB 159.9 MiB +0.1 MiB
PSS · last − first window -2.8 MiB +10.3 MiB +13.1 MiB
PSS · warm slope / 100 nav +0.3 MiB +1.6 MiB +1.2 MiB
Peak file descriptors 63 60 -3
Peak threads 31 31 0

HEAD memory by 50-navigation quarter

HEAD range Avg RSS Final RSS Peak RSS Avg PSS Final PSS Peak FD
1–50 161.0 MiB 151.2 MiB 239.8 MiB 157.5 MiB 147.6 MiB 51
51–100 160.7 MiB 144.2 MiB 199.7 MiB 157.1 MiB 140.5 MiB 50
101–150 160.3 MiB 154.8 MiB 176.2 MiB 156.6 MiB 151.2 MiB 50
151–200 163.9 MiB 145.9 MiB 198.6 MiB 160.7 MiB 143.1 MiB 51

Raw reports and per-navigation boundary samples: workflow run and full sequential-navigation-soak-results artifact.

Public-site timing and memory are observational. Use the A/B deltas and trend shape as evidence, not as a deterministic performance threshold.

@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

CI Regression Report

Source CI run · source state at render: in_progress · artifacts: 5/5

Check Status Signal
Release regression ✅ HEAD/base failures 0/0; raw binary −0.000189%
Frontend differential ✅ 1,020/1,020 cases matched; 0 issues
Agent episodes ✅ 8/8 Moli episodes passed; 0 failures
Runtime/CDP contracts ✅ 26 contract cases; 0 failures
CDP smoke ✅ 46/46 groups passed; 466 scenarios
Release regression — ✅ HEAD/base failures 0/0; raw binary −0.000189%

Package and image size

Metric Base HEAD Delta Delta %
Raw binary 149.14 MiB 149.14 MiB −296 B −0.000189%
Stripped binary 103.40 MiB 103.40 MiB 0 B 0.00%
gzip binary 50.17 MiB 50.17 MiB +265 B +0.000504%
Rootfs 156.04 MiB 156.04 MiB 0 B 0.00%
gzip rootfs 59.00 MiB 58.99 MiB −1.77 KiB −0.002928%

Startup latency and PSS

Case Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta
Serve ready 27.51 ms 27.17 ms −0.34 ms 4.70 MiB 4.69 MiB −14.50 KiB
CDP first page 52.88 ms 52.45 ms −0.43 ms 4.99 MiB 4.05 MiB −959.50 KiB
CDP warm page 14.04 ms 13.77 ms −0.27 ms 50.22 MiB 49.07 MiB −1.16 MiB
CLI about:blank 14.71 ms 14.21 ms −0.50 ms 4.38 MiB 3.20 MiB −1.18 MiB
CLI local JS 18.49 ms 17.40 ms −1.08 ms 4.04 MiB 3.60 MiB −452.50 KiB

Concurrency matrix

Concurrency Base p50 HEAD p50 Delta Base PSS HEAD PSS Delta HEAD failures Unstable B/H
1 16.20 ms 16.22 ms +0.02 ms 666.00 KiB 676.00 KiB +10.00 KiB 0 0/0
5 18.01 ms 18.00 ms −0.01 ms 23.39 MiB 22.35 MiB −1.04 MiB 0 0/0
10 19.51 ms 18.89 ms −0.62 ms 14.00 MiB 13.66 MiB −343.00 KiB 0 0/0
25 18.10 ms 18.97 ms +0.86 ms 13.48 MiB 25.98 MiB +12.50 MiB 0 0/0
100 19.04 ms 18.43 ms −0.62 ms 13.41 MiB 26.91 MiB +13.49 MiB 0 0/0
Frontend differential — ✅ 1,020/1,020 cases matched; 0 issues
Match DOM mismatch Diagnostic mismatch Moli error Reference error Infrastructure error Mismatched frames Duration
1,020 0 0 0 0 0 0 6m 27.89s
Agent episodes · Moli vs Chromium — ✅ 8/8 Moli episodes passed; 0 failures
Fast contract Episodes Passed Assertions Ready p50 Episode p50
Moli 8 8 47/47 3.27 ms 26.07 ms
Chromium 8 8 47/47 242.92 ms 82.17 ms
Operation p50 Chromium Moli Delta Delta %
navigate 43.38 ms 7.32 ms −36.06 ms −83.13%
observe 0.81 ms 0.88 ms +0.08 ms +9.68%
fill 4.35 ms 3.08 ms −1.27 ms −29.17%
click 4.65 ms 3.70 ms −0.94 ms −20.33%
Idle-resource episode Peak RSS Peak PSS Average CPU Peak CPU Peak processes Sampler
Moli 63.15 MiB 61.45 MiB 0.64% 10.00% 1 ✅
Chromium 1285.61 MiB 419.06 MiB 2.18% 86.11% 13 ✅
Runtime and CDP session contracts — ✅ 26 contract cases; 0 failures
Suite Cases Failures Median case p50 Median case p95 Median peak PSS p50
Synthetic fetch 13 0 15.92 ms 16.89 ms 781.00 KiB
Long-lived CDP session 13 0 19.21 ms 20.12 ms —
CDP smoke — ✅ 46/46 groups passed; 466 scenarios

Workers: 4 · cumulative group time: 127.14 s · failed groups: 0

Slowest group Scenarios Duration Status
chromium-cdp 56 12.28 s ✅
multi-page 45 10.71 s ✅
dom-input 27 10.51 s ✅
layout-screenshot 5 7.61 s ✅
core 35 6.94 s ✅

All artifact fields are parsed by the trusted default-branch renderer; missing or invalid inputs remain visible as unavailable.

Base automatically changed from fix/svg-create-rect to main September 8, 2026 12:38
@ldm0
fix(indexeddb): finish upgrade opens after transaction completion
5f491b6 
Retain the exact open request until normal transaction request draining and checkpoint deactivation complete. Publish open success or error in a separate task, handle aborted/closed provisional connections, and preserve FIFO among waiting open/delete requests.

Remove eager upgrade-completion and duplicate blocked-request dispatch paths. Update selected-task boundary regressions and add Chromium-calibrated CDP coverage for migration, microtasks, rollback, deletion order and SVG-gated application startup.
@ldm0
ldm0 force-pushed the fix/indexeddb-upgrade-order branch from a7938ba to 5f491b6 Compare September 8, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ldm0