Repository navigation
test: derive the chart pins and keep the fleet counts in one test; restore LibreDB last on the showcase - #1691
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…store LibreDB last on the showcase The chart description and keyword pins are derived from the engine list, the per-provider copies of the fleet count tuples become one test, and the showcase ranks BigQuery and Firestore before libSQL so the embedded LibreDB store is last again.
cevheri
force-pushed
the
test/derived-provider-pins
branch
from
October 12, 2026 14:12
280742f to
9abcc15
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only and listing change, so that a new provider does not have to edit another provider's tests.
tests/unit/chart-description.test.tsderives the chart description and keyword pins from the engine list, replacing the copy in the S3 provider-doc test.tests/unit/db/compatibility.test.ts.src/lib/db-showcase.tsranks BigQuery 29, so libSQL is 30 and the embedded LibreDB store is last again (31), as its comment says.Measured on this base: 32 shipped types, 31 external, 27 wire-compatible, 58 connectable products.
Checks: the full local gate set passed (1272 test files at 100% line coverage, build,
build:lib,attw).The login showcase is checked in a browser before this leaves draft.
No separate review agents ran on this branch.
Prepares the Snowflake provider (#424).