Repository navigation
fix(export): say a limited result writes the rows shown, not all rows - #1693
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
describeExportScope checks for a fetchable next page first; otherwise a result whose pagination says it was limited reads "Writes the <n> rows shown." with "The result was cut, so the file is not the whole result.", for a provider's own cut and for a route-bounded result on an engine with no Load More. docs/BACKLOG.md U42 is closed and removed.
cevheri
force-pushed
the
fix/export-scope-limited-results
branch
from
October 12, 2026 14:12
a64887a to
50874a3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export menu no longer says "Writes all rows." for a result that is not whole.
describeExportScopechecks for a fetchable next page first and keeps its sentences.pagination.wasLimitedis true reads "Writes the rows shown." with "The result was cut, so the file is not the whole result."docs/BACKLOG.mdU42 is closed and removed; the Prometheus doc and theWorkspacePropscomment are updated.Release note for embedding hosts: a host that sends
wasLimited: truefor a result that fit already shows the "limited" badge, and its export menu now also shows the cut sentence.Checks: the full local gate set passed (1271 test files at 100% line coverage, build,
build:lib,attw).The export menu is checked in a browser on three engines before this leaves draft.
No separate review agents ran on this branch.
Prepares the Snowflake provider (#424).