[notlakshitha]

Description

On PostgreSQL, EXPLAIN ANALYZE executes the statement it explains. The confirmation gate read the operative keyword EXPLAIN, which is not dangerous, so EXPLAIN ANALYZE DELETE and EXPLAIN ANALYZE DROP TABLE ran with no dialog. The gate now strips the option list and asks about the remaining statement when ANALYZE is on.

This builds on #1872 (the #1862 CTE confirmation change). A data-modifying CTE written under EXPLAIN ANALYZE asks for the same reason that CTE asks on its own.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code refactoring
• Performance improvement
• Test addition or update

Related Issue

Closes #1863

Changes Made

• PostgreSQL's grammar row sets explainExecutesWithAnalyze. CockroachDB uses the postgres type-id, so it shares that reading. Other dialects are unchanged.
• When a statement starts with EXPLAIN and ANALYZE (or the British ANALYSE) is enabled, the gate strips a run of ANALYZE / ANALYSE / VERBOSE, or a parenthesised option list, and evaluates the remaining text as its own statement.
• ANALYZE with no value, or set to true, on or 1, is on. false, off and 0 are off. A plain EXPLAIN only plans, so it does not ask, including an UPDATE … SET the unanchored probe would otherwise find. Words inside strings and comments are not options and are not the statement.

Testing

• I have tested this locally
• I have added/updated tests
• All existing tests pass

Test Environment

• LibreDB Studio Version: 1.0.0
• Browser: not used; the change is the gate predicate that decides whether the existing dialog opens
• OS: Ubuntu (Linux x86_64)
• Node.js/Bun Version: Node 24.16.0, Bun 1.4.2
• Database Type: PostgreSQL (CockroachDB shares the grammar)

bun tests/run-tests.ts tests/components/QuerySafetyDialog.test.tsx — 524 pass. bun run test:coverage — 1702 files, 62528 pass, 10 skip (18 files not run here because Helm or 7z is absent; CI runs those). bun run coverage:check — 180883/180883 lines (100.00%). bun run typecheck and bun run build passed. bun run lint reported 0 errors.

Screenshots (if applicable)

Not applicable. The dialog is unchanged; only which statements open it moved.

Checklist

• My code follows the project's code style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The required CI test job passes the 100% line-coverage gate (bun run test:coverage and bun run coverage:check)
• If I changed src/lib/db/providers/, I updated the matching docs/providers/ documentation and tests/integration/db/ tests in the same PR (provider triad)
• If the type-id has a non-null AGENT_STATEMENT_LANGUAGE row, I kept its agent leg in step: the engine overlay under src/lib/agent/languages/<statement-language>/engines/, the Agent language pack subsection of its provider document, and tests/unit/lib/agent/engine-docs.test.ts
• Any dependent changes have been merged and published

Additional Notes

The grammar flag lives on the PostgreSQL row (src/lib/db/providers/sql/postgres-sql-grammar.ts) and docs/providers/postgres.md describes it. There is no provider runtime change, so the integration suite was left as it is. The agent overlay is untouched.

This PR is stacked on #1872: it contains the #1862 commit plus one new commit for #1863. Please review #1872 first; once it merges this diff reduces to the #1863 commit alone.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cevheri]

I'm working on a VS Code extension for LibreDB Studio. I'll review the open PRs once it's ready.
Thanks for your patience!

https://marketplace.visualstudio.com/items?itemName=libredb.libredb-studio

[notlakshitha]

no rush at all, thanks! the vs code extension looks cool

[cevheri]

Thanks, the grammar flag is the right home for this and the option-list reading is careful.
Two things before it can go in:

1. EXPLAIN (ANALYZE 0x1) DELETE FROM users deletes every row on PostgreSQL 18.6 and the gate answers false; 0b1, 0o1 and 0_1 do the same. The number reader stops at the first non-digit, so 0x1 reads as 0.
   Done when: ANALYZE counts as off only for a whole value PostgreSQL reads as false, anything else counts as on, and these four spellings are test rows that ask.
2. This branch sits on the first commit of #1872, so it still carries the CTE-list reading that asks for a column named merge.
   Done when: rebased onto #1872 after it merges, with the docs conflict in query-optimization.md resolved and the full gate test file green.

[notlakshitha]

fixed the analyze value parsing, only real false values count as off now (so 0x1, 0b1, 0o1, 0_1 ask for confirmation). will rebase once 1872 is in