Repository navigation
libretro: report that states are incomplete - #63
Open
sunlollyking wants to merge 1 commit into
Open
sunlollyking wants to merge 1 commit into
sunlollyking wants to merge 1 commit into
Conversation
Loading a state reinitializes the system. A frontend that loads one every frame from power-on, as run-ahead does, keeps the game from ever booting and shows a black screen. Report RETRO_SERIALIZATION_QUIRK_INCOMPLETE so frontends don't rely on states for run-ahead or netplay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I play SNES games in Kodi with the run-ahead I'm adding to it, and with bsnes the screen stayed black. Run-ahead loads a state every frame, and loading a state reinitializes the system (
power(false)inSystem::unserialize), so from power-on the game never boots. Loading every frame once a game is already running is fine, and so is an occasional load.This reports
RETRO_SERIALIZATION_QUIRK_INCOMPLETE, which libretro.h describes as states that are fine for normal saves but shouldn't be relied on for frame-sensitive features. RetroArch's core info already lists bsnes asserializedrather thandeterministic, so RetroArch doesn't run it ahead, and the Kodi run-ahead holds off for a core that reports the quirk. The core's own run-ahead option is unaffected.Tested with Super Mario All-Stars + Super Mario World: