fix: SDL_RenderTextureTiled on Metal - infinite loop + memory allocs on an out of bounds src rect - #16025
Open
transmutrix wants to merge 1 commit into
Open
Conversation
…sed an oob source rect that touched the edge of the texture but had zero area
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds source rect area sanity check to
SDL_RenderTextureTiledandSDL_RenderTextureTiled_Iterate.Description
I had an occasional hard-to-repro freeze in my game where my main process would hit an infinite loop and allocate 25+ GB of RAM. I messed up some arithmetic on a timer value for an animation, and I was passing a bogus source rect for my texture to
SDL_RenderTextureTiled, one which had no area because it was out of bounds, but which still touched the edge of the texture, so passed through the existing checks.Existing Issue(s)