cocoa: Fix macOS 26 popup window regression in 3.4.14 - #16153
Open
rlanday wants to merge 1 commit into
Open
Conversation
The macOS 26 mouse workaround recomputes motion positions as the global mouse position minus SDL_GetWindowPosition(), but window positions are parent-relative for popup windows, so popups received coordinates offset by their parent's global origin. Unreachable before 3.4.14, when the workaround was widened beyond fullscreen spaces. Convert the position to global first with SDL_RelativeToGlobalForWindow(), a no-op for non-popup windows. Diagnosed by @pipiwoaini in libsdl-org#15967.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDL 3.4.14 widened the macOS 26 stale-mouse-motion workaround from fullscreen Spaces to all windows (958c4cb). The workaround recomputes each motion event's position as
SDL_GetGlobalMouseState()minusSDL_GetWindowPosition(), but window positions are parent-relative for popup windows, so popups received coordinates offset by their parent's global origin — or no usable motion events at all. The popup path was unreachable before 3.4.14 because a popup is never a fullscreen Space.This converts the window position to global with
SDL_RelativeToGlobalForWindow()before the subtraction. The helper is a no-op for non-popup windows, so top-level windows behave exactly as before — andSDL_cocoawindow.malready uses it for this conversion in four other places, so this applies the file's established pattern to the one call site that missed it.Diagnosed by @pipiwoaini in #15967 (comment).
Testing
testautomation: 374 passed, 0 failed, 2 skipped.Fixes #16152