feat: intermediary fee types (re-apply after #525 revert)#528
Open
ja88a wants to merge 6 commits into
Open
Conversation
Promotes the partner-provided distributionFees request parameter to the public type surface alongside intermediary. RouteOptions and QuoteRequest both gain distributionFees?: DistributionFee[]; QuoteToAmountRequest inherits via Omit<QuoteRequest, ...>. JSDoc documents per-entry constraints (decimal percentage, EVM receiver, sum cap, ~10 entry hard cap) without exporting numeric constants — limits stay backend policy, not part of the SemVer contract.
`FeeCost.feeSplit` was an inline anonymous shape; expose it as the named `FeeSplit` interface so downstream consumers (lifi-backend, lifi-sdk) can import it directly instead of writing `NonNullable<FeeCost['feeSplit']>`. Pure factoring — shape, JSDoc semantics, and field set are unchanged. `FeeRecipient` JSDoc also reflowed to single-line blocks for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-introduces the
FeeSplit/FeeRecipient/intermediaryfee surface from #520, which was reverted in #525 so that@lifi/typescould ship17.81.xcleanly while the consumer-side rollout inlifi-backend(CORE-213, PR #8187) was still in flight.This PR re-applies the same diff and publishes
@lifi/types@17.83.0-alpha.0(alpha channel) solifi-backendcan pin against the alpha while #8187 stabilizes.main @ 17.82.1(post-revert).feat: intermediary fee types (re-apply after #525 revert)— diff is exactlysrc/api.ts+src/step.tsadditions from feat: intermediary fee types #520.v17.83.0-alpha.0→ triggers.github/workflows/publish.yaml→ npm@lifi/types@17.83.0-alpha.0under dist-tagalpha.Coordination
A parallel beta cycle for
17.83.0is in flight onfeat/EXBE-273-constraign-solana-swap-tx-size(v17.83.0-beta.0already published). Both prereleases can coexist on npm under separate dist-tags. Whichever cuts stable17.83.0first wins the slot; the loser bumps to17.84.0.Merge plan
Do not squash-merge until
lifi-backendPR #8187 is approval-ready. Sequence:@lifi/types@17.83.0-alpha.0.17.83.0frommain(pnpm release).lifi-backendcatalog from17.83.0-alpha.0→17.83.0and merge #8187.Test plan
publish.yamlworkflow green forv17.83.0-alpha.0npm view @lifi/types@17.83.0-alpha.0 versionreturns17.83.0-alpha.0lifi-backendconsumer bump PR opens with green typecheck/build against the alpha