Repository navigation
Harden Config Parsing / Validation - #268
Merged
benthecarman merged 4 commits intoSep 24, 2026
Merged
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
benthecarman
force-pushed
the
codex/loupe-client-config
branch
from
September 1, 2026 02:45
a56ef0c to
36cc238
Compare
benthecarman
requested review from
joostjager
and removed request for
wpaulino
September 1, 2026 16:35
joostjager
previously approved these changes
Sep 2, 2026
benthecarman
force-pushed
the
codex/loupe-client-config
branch
from
September 2, 2026 20:55
36cc238 to
9d03f24
Compare
Stop API key resolution when a loaded configuration names an unsupported network. This prevents a malformed config from selecting the Bitcoin key. This commit was created with assistance from Codex.
benthecarman
force-pushed
the
codex/loupe-client-config
branch
from
September 4, 2026 02:45
9d03f24 to
72341f0
Compare
joostjager
reviewed
Sep 4, 2026
joostjager
left a comment
joostjager
left a comment
Contributor
There was a problem hiding this comment.
Seems something went wrong in the rebase? https://github.com/lightningdevkit/ldk-server/pull/268/changes#r3912262959 was addressed, but then reverted again in the second push.
Also it would be helpful for review to get a link with the diff that addresses the comments, excluding the rebase. I am not sure what happened.
Collaborator
Author
|
sorry fixed, here is link for easy review |
joostjager
previously approved these changes
Sep 22, 2026
Stop API key lookup after an explicit storage directory is selected. A missing instance key must not fall back to another node's credentials. This commit was created with assistance from Codex.
Return an error when the operator selects a config path that is missing or is not a file. This prevents silent fallback to the default node. This commit was created with assistance from Codex.
Return an error when an explicit MCP config path is missing or is not a file. This prevents the bridge from selecting the default node instead. This commit was created with assistance from Codex.
benthecarman
force-pushed
the
codex/loupe-client-config
branch
from
September 22, 2026 19:02
0cee20c to
a7f1bb6
Compare
Collaborator
Author
|
Just the fixed invalid network validation |
joostjager
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various issues by project loupe where we could silently fallback to a default config or file location in an unexpected way. Better to force the user to be explicit upfront to prevent potential issues.