This repository was archived by the owner on Oct 9, 2026. It is now read-only.
Repository navigation
Publish the v2 reference-timestamp symlink - #109
Open
vincenzopalazzo wants to merge 1 commit into
Open
vincenzopalazzo wants to merge 1 commit into
vincenzopalazzo wants to merge 1 commit into
Conversation
v2 clients persist the snapshot header and request that timestamp next. The empty delta was written for both versions, but its public symlink was created only in the v1 directory, so the v2 follow-up was HTTP 404. Fixes lightningdevkit#108
|
I've assigned @TheBlueMatt as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108.
A v2 client stores the timestamp in the snapshot header and requests
/snapshot/v2/<that timestamp>next.serialize_deltarounds that value toreference_timestamp, and the empty delta for that timestamp is what keeps the follow-up from 404ing.The empty file was already written for both versions. Its public symlink was created once, outside the version loop, and only in the v1 directory:
There was no
symlinks/v2/{reference_timestamp}.bin. The real delta links already use(suffix, path_to_root)for both versions (dc32c3147). This applies the same pair to the dummy symlink, so v2 resolves to../../snapshots/v2/empty_delta.lngossip.test_full_snapshot_persistencenow reads that v2 symlink and applies it. It stays an empty graph.Related: lightningdevkit/ldk-server#201