Skip to content

ci: prod デプロイを直列化して CloudFormation の競合を防ぐ（#114） #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limit7412 merged 1 commit into from
Aug 9, 2026
Merged

ci: prod デプロイを直列化して CloudFormation の競合を防ぐ（#114） #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/serverless-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,22 @@ on:
push:
branches: [master]

# master へ短時間に複数回マージすると deploy が並走し、スタック
# github-notifications-slack-prod が UPDATE_IN_PROGRESS のままで後発が
# 落ちうる。dev 側（issue #112 / PR #113）と同じ理由なので同じ形で防ぐ
# （issue #114）。
#
# cancel-in-progress は false。実行中のデプロイを打ち切るとスタックが
# 中途半端な状態で残りうるため、待たせる方を選ぶ。
#
# 待機中の run は最新 1 本しか保持されず、3 回続けてマージすると中間の run は
# キャンセルされる。prod は master の内容をデプロイするので、最新の run さえ
# 通れば最終状態は正しく、むしろ無駄なデプロイが減る。dev と違いこのキャンセルは
# 実害にならない。
concurrency:
group: serverless-prod
cancel-in-progress: false

jobs:
deploy:
name: deploy
Expand Down
Loading