fix: proxy options in ItemController#1563
Merged
Merged
Conversation
The correct context is http->proxy : https://www.php.net/manual/en/context.http.php
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
Can please someone check this ? Thanks |
KodeStar
approved these changes
Jul 8, 2026
KodeStar
left a comment
KodeStar
left a comment
Member
There was a problem hiding this comment.
Correct fix. PHP stream contexts nest proxy under the http wrapper ($options['http']['proxy']); the previous $options['proxy']['http'] created a non-existent proxy wrapper so the HTTPS_PROXY setting was silently ignored during icon downloads. Verified the full test suite stays green. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct context is http->proxy :
https://www.php.net/manual/en/context.http.php