fix: bind SIP media sockets to signaling interface#659
Open
8thgencore wants to merge 1 commit intolivekit:mainfrom
Open
fix: bind SIP media sockets to signaling interface#6598thgencore wants to merge 1 commit intolivekit:mainfrom
8thgencore wants to merge 1 commit intolivekit:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
========================================
Coverage 65.25% 65.26%
========================================
Files 51 37 -14
Lines 6588 7148 +560
========================================
+ Hits 4299 4665 +366
- Misses 1915 2012 +97
- Partials 374 471 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change binds SIP media sockets to the same local interface used for SIP signaling instead of listening on
0.0.0.0.Problem
In multi-homed / NATed production environments, SIP signaling and RTP could leave the host through different interfaces/IPs:
0.0.0.0Some SIP providers validate that registration/signaling and call media originate from the same IP. In our case this caused providers to reject calls as illegitimate.
Change
BindIPtoMediaOptionsNewMediaPortWithto bind RTP sockets toBindIPwhen providedSignalingIPLocalasBindIPfor both outbound and inbound SIP mediaExpected result
RTP now uses the same local interface as SIP signaling, which makes the effective external path much more stable and avoids cases where providers reject calls because signaling and media appear to originate from different IPs.
Notes
This change is intentionally narrow: