Inline sink emit calls#196
Merged
carole-lavillonniere merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
Collaborator
Author
|
@claude review once |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
carole-lavillonniere
force-pushed
the
refact-pr-127-2
branch
3 times, most recently
from
ad41d18 to
5ad97b8
Compare
carole-lavillonniere
force-pushed
the
refact-pr-127-2
branch
from
5ad97b8 to
73aec8d
Compare
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
thrau
approved these changes
Apr 28, 2026
Member
thrau
left a comment
thrau
left a comment
There was a problem hiding this comment.
This is a really nice refactor to move us towards a more object-oriented codebase! LGTM
silv-io
approved these changes
Apr 29, 2026
Comment on lines
+79
to
+93
| // Event is a sealed marker — only event types in this package implement it, | ||
| // so Sink.Emit rejects unknown types at compile time. | ||
| type Event interface{ sealedEvent() } | ||
|
|
||
| func (MessageEvent) sealedEvent() {} | ||
| func (SpinnerEvent) sealedEvent() {} | ||
| func (ErrorEvent) sealedEvent() {} | ||
| func (AuthEvent) sealedEvent() {} | ||
| func (InstanceInfoEvent) sealedEvent() {} | ||
| func (TableEvent) sealedEvent() {} | ||
| func (ResourceSummaryEvent) sealedEvent() {} | ||
| func (ContainerStatusEvent) sealedEvent() {} | ||
| func (ProgressEvent) sealedEvent() {} | ||
| func (UserInputRequestEvent) sealedEvent() {} | ||
| func (LogLineEvent) sealedEvent() {} |
Member
There was a problem hiding this comment.
As mentioned in-sync, I think we can remove that seal in the future and just define the Event interface more clearly and then move the Events to their domains.
But that's a future optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring addressing suggested improvement #1 from @thrau in this comment #127 (review)
The goal is to make reading the code easier, be more explicit and idiomatic go, and remove some lines of code.
Changes
EmitXxx(sink, ...)helpers with directsink.Emit(output.XxxEvent{...})calls at all sitesEventfrom a generic union constraint to a sealed marker interface (sealedEvent()unexported method), enabling an exportedSink.Emit(event Event)without genericsSpinnerStart/SpinnerStop/SpinnerStartWithDurationas value constructors (they encode theMinDurationdefault)