Repository navigation
Conversation
…dule `general.ts` was at the 300-line `max-lines` limit, so the pruning of `x-logto-dev-feature` marked document parts moves to `dev-feature.ts` together with the marker itself. The module also gains `removeDevFeatureResponseHeaders`, which drops a dev-marked response header while the marker is still present, and is wired into `assembleSwaggerDocument` before the schema pruning that strips every marker. Nothing in the repository marks a response header yet, so the served documents are unchanged; this is the plumbing the Account API step-up work needs to hide its new header. Amp-Thread-ID: https://ampcode.com/threads/T-01a14383-fded-744a-b90a-56f48926c865
This was referenced Oct 16, 2026
fix(core): require a first-party application for account reads that need recent authentication
#9773
Open
Contributor
Author
|
Dropping this: it existed only to hide the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/general.tssat exactly at the 300-linemax-lineslimit, so there was no room for the response-header pruning the Account API step-up work needs. The dev-feature plumbing moves toutils/dev-feature.ts:devFeatureSchemaExtension,removeDevFeatureParameters, andremoveDevFeatureSchemaPropertiesmove as they are.removeDevFeatureResponseHeadersis new: it drops a response header marked withx-logto-dev-featurewhile the marker is still on it, and is called fromassembleSwaggerDocumentbeforeremoveDevFeatureSchemaProperties, which strips the marker from every record unconditionally.general.test.tsgains the two cases for the new pruning, and the moved imports and tests point at the new module.Nothing in the repository marks a response header yet, so the served documents are unchanged and no changeset is needed. This is plumbing: the header it hides is added by the Account API step-up change.
Part of LOG-14124.
Testing
Unit tests: the new pruning cases run with dev features both disabled and enabled, and assert that the internal marker never reaches the document.
Checklist