Repository navigation
fix(experience): skip step-up interaction check in preview - #9939
Merged
Merged
Conversation
The Console sign-in experience preview has no OIDC interaction, so the StepUpEntryGuard fallback request to GET /api/experience/interaction always failed with 400. Treat the preview as a normal sign-in without reading the interaction. Amp-Thread-ID: https://ampcode.com/threads/T-01a18b06-5f12-7239-aa41-f11b1d9657d5
simeng-li
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sign-in experience preview in Console sent
GET /api/experience/interactionon every load and got a 400 response.StepUpEntryGuardonly trusts the flow cookie's step-up hint when itsappIdmatches the tab'sapp_idin session storage. The preview iframe is not opened by a login prompt, so it has noapp_id. The guard then falls back to reading the interaction, which does not exist in the preview.The guard now treats the preview as a normal sign-in and renders the entry route without reading the interaction.
Testing
Unit tests
Checklist
.changeset