Repository navigation
kit: Update GPUI to gpui-pre 0.3.6 - #3147
Merged
Merged
Conversation
…ctory Zed changed `App::register_inspector_element` to take a factory that runs per window and returns the renderer, so the inspector builds its `DivInspector` there instead of caching one in a `OnceCell`. This is the adaptation gpui-pre 0.3.6 needs; the version bump follows once the snapshot is published. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Zed 395def7a, published by the Release GPUI workflow on 2026-09-21. The inspector change on this branch is the one adaptation the snapshot needs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
huacnlee
added a commit
that referenced
this pull request
Sep 21, 2026
…#3163) ## Summary gpui-kit 0.6.4 on crates.io declares `gpui-pre ^0.3.5`. The weekly Release GPUI run published 0.3.6 this morning with a changed `register_inspector_element` signature, so every fresh build of 0.6.4 now resolves 0.3.6 and fails with E0593 in gpui-component's `inspector.rs` (#3156). Main was already adapted to 0.3.6 in #3147; only the published crates are broken, because they carry the workspace requirement to crates.io verbatim. - Pin every `gpui-pre-*` snapshot crate (and the hand-published `gpui-pre-reqwest`) with `=x.y.z` in the workspace `Cargo.toml`, so a gpui-kit release keeps resolving the snapshot it was tested with and a new snapshot only reaches applications through a release that bumps the pin. - Add `script/check-gpui-pin.ts` (Bun), run in the CI `checks` job. It fails on a requirement that is not exact, on snapshot crates pinned to more than one version, and on a manifest with no snapshot dependency at all. - Teach `bump-gpui.ts`'s kit check to move the workspace pins onto the staged version for the duration of the check, since a `[patch]` only applies to a source that satisfies the requirement, and to restore `Cargo.toml` afterwards. The rewrite is covered by `--self-test`. - Document the pin policy and the bump procedure in `CONTRIBUTING.md`, which still described publication as paused on an incompatible snapshot (it publishes either way since #3148). `Cargo.lock` is unchanged: it already resolves 0.3.6. A 0.6.5 release from `main` is what fixes crates.io users; until then 0.6.4 builds with `cargo update -p gpui-pre -p gpui-pre-platform -p gpui-pre-web -p gpui-pre-macros -p gpui-pre-sum-tree -p gpui-pre-reqwest-client --precise 0.3.5`. Closes #3156 ## Test Plan - `bun script/check-gpui-pin.ts` passes on the repository manifest and fails on fixtures with caret requirements, mixed snapshot versions, and no snapshot dependency - `bun script/bump-gpui.ts --self-test` - `cargo metadata --locked` and `cargo check -p gpui-kit --locked` (lockfile unchanged) - `typos`, `git diff --check` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpui-pre-*dependencies from 0.3.5 to 0.3.6, published from Zed395def7a067b32ed598fcb3f048969ada9b54942by the Release GPUI workflow on 2026-09-21 (first run after gpui-pre: Inject staged crates as git dependencies in the kit check #3146 fixed the kit check).crates/component/src/inspector.rsto Zed's newApp::register_inspector_element, which now takes a per-window factory that returns the renderer. TheDivInspectoris created inside that factory instead of being cached in aOnceCell, following Zed's owninspector_ui.The Release GPUI workflow ran on this branch with the inspector commit and published 0.3.6, so the repository is known to build and pass its tests against the snapshot.
Test Plan
cargo check --workspace --all-targets, Clippy and the full test suite against staged 0.3.6 (the run that published it).RUSTFLAGS=-D warnings cargo clippy --workspace --exclude gpui-shell --locked -- --deny warnings(the CI lint command).cargo fmt --check.Public API
No public API changes.
🤖 Generated with Claude Code