Skip to content

notification: Fix center notification stacks reliably on web - #3149

Merged
huacnlee merged 3 commits into
mainfrom
fix/notification-top-center-alignment
Sep 21, 2026
Merged

huacnlee merged 3 commits into
mainfrom
fix/notification-top-center-alignment

Conversation

@huacnlee

Copy link
Copy Markdown
Member

Summary

  • position horizontally centered notification stacks inside a full-width flex wrapper
  • avoid relying on conflicting absolute offsets and automatic margins
  • add a layout regression test for Anchor::TopCenter

Closes #3137

Test Plan

  • cargo test -p gpui-component notification::tests --lib
  • cargo clippy -p gpui-component --lib --tests -- -D warnings
  • git diff --check

Use a full-width flex positioning wrapper for horizontally centered notification placements and cover TopCenter with a layout regression test.

Co-authored-by: Codex <codex@openai.com>
@huacnlee huacnlee changed the title fix: center notification stacks reliably notification: Fix center notification stacks reliably on web Sep 21, 2026
huacnlee and others added 2 commits September 21, 2026 18:12
Build the Story WASM assets before starting the Astro documentation site, and retain the standalone gallery workflow as dev-gallery.

Co-authored-by: Codex <codex@openai.com>
Keep absolute positioning in its original shared location and center only the horizontal placements with an explicit 50% offset.

Co-authored-by: Codex <codex@openai.com>
@huacnlee
huacnlee enabled auto-merge (squash) September 21, 2026 10:26
@huacnlee
huacnlee disabled auto-merge September 21, 2026 10:26
@huacnlee
huacnlee enabled auto-merge (squash) September 21, 2026 10:26
@huacnlee
huacnlee merged commit 0b3e53d into main Sep 21, 2026
11 checks passed
@huacnlee
huacnlee deleted the fix/notification-top-center-alignment branch September 21, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anchor::TopCenter notification is left-aligned instead of centered

1 participant