Repository navigation
feat: vi-mode indicator - #30
Merged
Merged
Conversation
youssefadly237
marked this pull request as draft
August 19, 2025 20:50
youssefadly237
marked this pull request as ready for review
September 2, 2025 19:30
Collaborator
Author
|
xournalpp/xournalpp#6601 is merged |
Owner
|
Looks great! Do you know when the commit will make it into a (non-nightly) release? |
Collaborator
Author
|
not sure tbh, but it should not affect the non nightly users |
Collaborator
Author
|
this needs to be refactored will be done by tomorrow |
youssefadly237
force-pushed
the
toolbar_indicator
branch
from
March 2, 2026 23:34
4b73c9a to
661b8ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is implements
registerPlaceholder,setPlaceholderValuefrom Xournal's Lua API to establish mode indicator for vi-xournalapp, without breaking older versions of Xournal++The tool gets added to the toolbar like any other tool
changes live by changing the mode
closes #2