add include in cmake lists - #284
Open
Lixue9jiu wants to merge 5 commits into
Open
Conversation
Lixue9jiu
marked this pull request as ready for review
July 5, 2026 03:28
bjorn
reviewed
Jul 15, 2026
Contributor
|
Did you push the commit to a wrong branch? |
Yes. I didn't realize that's how GitHub work. |
This reverts commit e9f5a55.
Co-authored-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the end user to do
and get the include directories set up by CMake, without defining the include directory manually.
It provides better integration with the CMake build system.