Repository navigation
docs: use an explicit locale for the English month example - #13
Merged
lukeed merged 2 commits intoSep 22, 2026
Merged
Conversation
lukeed
reviewed
Sep 22, 2026
| // - Overrides {DD} | ||
| const stamp = tinydate('Today is: {MMMM} {DD}, {YYYY}', { | ||
| MMMM: d => d.toLocaleString('default', { month: 'long' }), | ||
| MMMM: d => d.toLocaleString('en-US', { month: 'long' }), |
Owner
There was a problem hiding this comment.
This is the only line that mattered
Contributor
Author
There was a problem hiding this comment.
Thanks — I've narrowed the PR to that locale change and reverted the two date-constructor edits.
Likio3000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom dictionary example can produce a translated month such as
juliowhile its documented output saysJuly. Selecten-USexplicitly so the month matches the English example output.Checked the dictionary callback against the implementation and existing assertions. A small built-in Date/Intl check reproduced the default-locale difference and confirmed the explicit English month under English and Spanish default locales. The tinydate suite and browser tests were not run. Prepared and reviewed with AI assistance.