fix(client): skip service DNS records on non-bridge networks - #186
Merged
Merged
Conversation
raw.dnsmasq is a bridge-only option, so on an OVN network every up/start/stop failed and the stack could never converge. Fixes lxc#185 Signed-off-by: Alessandro Dentella <sandro.dentella@gmail.com>
Member
|
Nice one! I'll cherry-pick into the main - 1.3 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185
raw.dnsmasqis a bridge-only option, but the DNSWatcher wrote it to everynetwork of the project, so with an external OVN network every
up/start/stopfailed mid-phase and the stack could never converge(details in #185).
updateDNSAliasesnow returns early on networks whose type is notbridge,with a debug log. On OVN networks instance names already resolve through the
network's own DNS, so the only loss is the service-name round-robin, which
raw.dnsmasqcannot provide there anyway.Tested on a 3-node Incus 7.3 cluster (OVN + Linstor):
up -dexits 1 withInvalid option ... "raw.dnsmasq"; patched it converges (exit 0,idempotent on re-run) and
--debugshowsskipping service DNS records: network is not a bridge ... type=ovn.upand removed on
down.