Skip to content

log that job logs are persisted in cleanup instead of normal close path #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlin4194 merged 1 commit into from
May 4, 2026
Merged

log that job logs are persisted in cleanup instead of normal close path #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/neptune/temporalworker/job/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ func (s *StorageBackendJobStore) Remove(jobID string) {
func (s *StorageBackendJobStore) Cleanup(ctx context.Context) error {
failedJobs := []string{}
for jobID, job := range s.InMemoryStore.GetJobs() {
s.logger.WarnContext(ctx, fmt.Sprintf("job: %s was not persisted before shutdown, persisting now during cleanup", jobID))
_, err := s.storageBackend.Write(ctx, jobID, job.Output)

// Track failed jobs, log errors and continue with other jobs
Expand Down
Loading