Skip to content

fix: CSS typo, btoa unicode, denoise validation, title flash#1663

Open
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix-reframe-batch-1
Open

fix: CSS typo, btoa unicode, denoise validation, title flash#1663
saurabhhhcodes wants to merge 1 commit into
magic-peach:mainfrom
saurabhhhcodes:fix-reframe-batch-1

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Jul 12, 2026

Copy link
Copy Markdown

Fixes #1659
Fixes #1660

Summary

  • Correct the details > summary selector so disclosure summaries receive the intended styling.
  • Encode shared recipe JSON before Base64 conversion and decode it symmetrically, allowing Unicode recipe text in Copy Link URLs.

Validation

  • npm install --package-lock=false --legacy-peer-deps --ignore-scripts --no-audit --no-fund
  • npm run build
  • Direct Unicode share-link round-trip assertion
  • git diff --check

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @saurabhhhcodes

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design labels Jul 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @saurabhhhcodes!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the level:beginner Beginner level - 20 pts label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] btoa crashes on Unicode characters in Copy Link [Bug] CSS typo detail instead of details selector

1 participant