feat: add dismissible privacy-advantage banner above the upload area#1666
Open
Subramaniyajothi6 wants to merge 1 commit into
Open
feat: add dismissible privacy-advantage banner above the upload area#1666Subramaniyajothi6 wants to merge 1 commit into
Subramaniyajothi6 wants to merge 1 commit into
Conversation
Surfaces Reframe's core differentiator — all video processing is 100% local. Adds a PrivacyBanner shown above the upload area before a file is loaded, dismissible via a close button with the dismissal remembered in localStorage for 7 days. - New src/components/PrivacyBanner.tsx using --surface/--border/--accent - Verified in light, dark, and high-contrast themes; readable at 375px Closes magic-peach#679
|
@Subramaniyajothi6 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @Subramaniyajothi6Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:intermediate
Contributor
👋 Thanks for your PR, @Subramaniyajothi6!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reframe's biggest differentiator — that video processing is 100% local, nothing is ever uploaded — was not communicated anywhere in the UI. This adds a small, dismissible privacy banner above the upload area so the benefit is obvious on first visit.
Closes #679
What changed
src/components/PrivacyBanner.tsx— a self-contained, dismissible banner.src/components/VideoEditor.tsx— renders{!file && <PrivacyBanner />}above the upload card.Behaviour
--surface,--border,--accent,--text,--muted), so it adapts to light, dark, and high-contrast themes automatically.localStorage(reframe_privacy_banner_dismissed_until); it stays hidden for 7 days.output: "export".Acceptance criteria
Testing
next lint— clean on the changed filestsc --noEmit— no errors from the changed files@magic-peach please review this PR .