Skip to content

fix(a11y): improve keyboard focus indicators and navigation#1668

Open
Antra1705 wants to merge 1 commit into
magic-peach:mainfrom
Antra1705:fix/keyboard-focus-indicators
Open

fix(a11y): improve keyboard focus indicators and navigation#1668
Antra1705 wants to merge 1 commit into
magic-peach:mainfrom
Antra1705:fix/keyboard-focus-indicators

Conversation

@Antra1705

Copy link
Copy Markdown

Description

Replaces the low-contrast :focus-visible box-shadow (12% opacity --accent-muted) with a prominent 2px offset ring using --accent and --bg CSS variables. Adds a high-contrast mode fallback, refactors NativeShareButton hardcoded blue colors to design system tokens, adds .thumb-btn:focus-visible styles to ThumbnailStrip, adds focus rings to DraggableTextOverlays, updates BaseButton with focus-visible:* Tailwind classes, and adds a KeyboardNavigation.test.tsx integration test covering Tab navigation and keyboard activation.

Related Issue

Closes #719

Type of Contribution

  • Bug fix
  • GSSoC contribution

Participant Info

  • GitHub username: @Antra1705
  • Contribution level: Advanced

Screen Recording

Screen.Recording.2026-07-14.at.10.04.45.PM.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

Signed-off-by: Antra1705 <antra.1705@gmail.com>
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

@Antra1705 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Antra1705

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Antra1705!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:feature New feature type:testing Testing labels Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:feature New feature type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve keyboard focus indicators and keyboard navigation for toolbar and controls

1 participant