machine/keyboard: add natural-keyboard control characters to generic_keyboard#15530
Open
davidlrand wants to merge 1 commit into
Open
machine/keyboard: add natural-keyboard control characters to generic_keyboard#15530davidlrand wants to merge 1 commit into
davidlrand wants to merge 1 commit into
Conversation
…keyboard The generic_keyboard device, used by serial terminals through SERIAL_TERMINAL and similar, emits control codes from its emulated keyboard but could not produce them from the natural keyboard: the Ctrl modifier was mapped to UCHAR_MAMEKEY(LCONTROL) rather than the natural-keyboard control modifier, and the letter keys carried no control-code character. Map Ctrl to UCHAR_SHIFT_2 and add the matching control code (0x01-0x1a) as a third PORT_CHAR on each letter key, following the convention ie15_kbd already uses. Ctrl+letter can now be typed with -natural. Found while bringing up the National Semiconductor ICM-3216, whose console is a generic serial terminal that needs Ctrl to reach the ROM monitor and shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic_keyboard device, used by serial terminals through
SERIAL_TERMINAL and similar, emits control codes from its emulated
keyboard but could not produce them from the natural keyboard: the Ctrl
modifier was mapped to UCHAR_MAMEKEY(LCONTROL) rather than the
natural-keyboard control modifier, and the letter keys carried no
control-code character.
Map Ctrl to UCHAR_SHIFT_2 and add the matching control code (0x01-0x1a)
as a third PORT_CHAR on each letter key, following the convention
ie15_kbd already uses. Ctrl+letter can now be typed with -natural.
Found while bringing up the National Semiconductor ICM-3216, whose
console is a generic serial terminal that needs Ctrl to reach the ROM
monitor and shell.